Fix auth bug that didn't terminate route on auth error

Signed-off-by: Gary Greene <greeneg@tolharadys.net>
greeneg · Mar 24, 2024 · ededb60 · ededb60
1 parent ca7468f
commit ededb60
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/middleware/authen.go b/middleware/authen.go
@@ -65,6 +65,7 @@ func AuthCheck(c *gin.Context) {
 			if err := session.Save(); err != nil {
 				c.IndentedJSON(http.StatusInternalServerError,
 					gin.H{"error": "failed to save user session"})
+				// session saving is not fatal, so allow them to proceed
 			}
 			log.Println("INFO: Authenticated")
 		} else {
@@ -81,6 +82,7 @@ func AuthCheck(c *gin.Context) {
 		if err != nil {
 			log.Println("ERROR: " + string(err.Error()))
 			c.IndentedJSON(http.StatusUnauthorized, gin.H{"error": "unable to authenticate: " + err.Error()})
+			c.Abort()
 			return
 		}
 		status := helpers.CheckIsNotLocked(user)