[teleport-update] Fix usage of default $PATH dir #52604
Merged
+76
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
added
the
no-changelog
vapopov
approved these changes
Feb 28, 2025
hugoShaka
approved these changes
Feb 28, 2025
public-teleport-github-review-bot
bot
removed request for
tcsc and
smallinsky
sclevine
force-pushed
the
sclevine/autoupdates-path-fix
branch
from
aa2c1bc to
e0ff6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect usages of the default $PATH dir introduced in #52152.
The default $PATH for the specified install suffix (
--install-suffix) can be overridden via the--pathflag. Currently, custom--pathvalues are ignored when writing the Teleport service file and logging a warning.This PR also fixes a regression where the proxy is not parsed from teleport.yaml on
teleport-update enable, and adjusts locking in main.go to avoid hanging.The
teleport-updatebinary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/opt/teleport.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/11856