Add version incompatibility warning to Connect #51832
Conversation
gzdunek
force-pushed
the
r7s/version-compat
branch
from
9ca0592 to
3fd1f1e
Compare
|
@ravicious, I added the UI: In the end I didn't use the tsh copy, it was too long. |
| size="small" | ||
| onClick={props.disableVersionCheck} | ||
| > | ||
| <Cog size="small" mr={1} /> |
There was a problem hiding this comment.
I wanted it to indicate that it's a config option :p
Also, handle TOO_OLD first to mirror lib/client/api.go.
| as="a" | ||
| href={buildDownloadUrl(props.platform)} | ||
| target="_blank" | ||
| <ActionButton |
There was a problem hiding this comment.
@gzdunek I've adjusted the buttons slightly so that they look the same way as primaryAction/secondaryAction from Alert. The cog icon was a nice touch, but with the new buttons there wasn't enough space for it.
I also removed the wildcards from the warning about the client being too old and updated the UIs to get rid of the -aa suffix when showing min version.
There was a problem hiding this comment.
Next time we can think of adding some kind of a prop to alert to control where the action buttons are shown, as we now at least have two places for that. Though maybe that's something we should consult with the design team.
ravicious
added
backport/branch/v17
no-changelog
ravicious
removed
the
no-changelog
| @@ -119,6 +122,9 @@ export function ClusterLoginPresentation({ | |||
| clearLoginAttempt={clearLoginAttempt} | |||
| shouldPromptSsoStatus={shouldPromptSsoStatus} | |||
| passwordlessLoginState={passwordlessLoginState} | |||
| shouldSkipVersionCheck={shouldSkipVersionCheck} | |||
| disableVersionCheck={disableVersionCheck} | |||
| platform={platform} | |||
There was a problem hiding this comment.
There's a fair share of prop drilling, but this is because useClusterLogin doesn't use a context and the login modal is written in the old style.
ravicious
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
|
Amplify deployment status
|
Closes #32555.
This PR refactors the version compatibility detection logic from tsh so that it can be reused in Connect. Then we use it to display a version compatibility warning in Connect when logging in to a cluster.
changelog: Added version compatibility warnings to Teleport Connect when logging in to a cluster