Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing new before Uri in ExporterSettings #90

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add missing new before Uri in ExporterSettings #90

merged 1 commit into from
Mar 26, 2024

Conversation

NielsPilgaard
Copy link
Contributor

Fixes a typo

Changes

I added new before Uri, allowing the code to compile without modification.

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

pyohannes
pyohannes approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting this @NielsPilgaard.

@pyohannes pyohannes merged commit c7b0c6e into grafana:main Mar 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

@matt-hensley matt-hensley Awaiting requested review from matt-hensley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NielsPilgaard @CLAassistant @pyohannes