Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix copyloopvar finding #133

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

dominikschulz
Copy link
Member

No description provided.

dominikschulz and others added 2 commits September 30, 2024 19:43
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@guillermodotn
Copy link
Contributor

I have created this PR to your fork branch dominikschulz:fix/lint.

It should fix the workflow Build gopass-jsonapi / macos.

Have a look in case you want to include it.

Add arc browser to the list of valid browsers.
@dominikschulz
Copy link
Member Author

@guillermodotn Thanks a lot :)

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@guillermodotn
Copy link
Contributor

guillermodotn commented Oct 5, 2024

Hello @dominikschulz,

I just realized the problem now. I submitted a couple of additional commits to your branch; please check them out.

I believe the refactoring of TestValidBrowsers can be useful for avoiding future conflicts.

@dominikschulz dominikschulz merged commit 66fef18 into gopasspw:master Oct 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants