Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gopass-jsonapi configuration for Brave on Windows #132

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

guillermodotn
Copy link
Contributor

Summary

This pull request implements a fix for the issue with gopass-jsonapi configuration for Brave on Windows.

Changes

  • Updated the registry path for Brave integration.
  • Verified that the configuration works as expected.

Related Issue

Fixes #131

Fix gopass-jsonapi configuration for Brave on Windows

- Updated the registry path used for Brave Browser to align with the Chromium configuration.
- Ensured that gopass-jsonapi correctly recognizes Brave as a native messaging host by adjusting the path to:
```
Software\Google\Chrome\NativeMessagingHosts\
```
- Verified that the updated configuration works seamlessly with Brave.

Signed-off-by: Guillermo N. Leiro Arroyo <guillerm0.n@outlook.es>
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking around on the web, that looks like it's the case that Brave has changed at some point to use that indeed ^^''
But I also don't have any Windows Brave installation handy to double check.

@dominikschulz dominikschulz merged commit 7238fba into gopasspw:master Oct 5, 2024
4 of 6 checks passed
@guillermodotn guillermodotn deleted the patch-1 branch October 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave configuration on Windows 11 not working.
3 participants