[ENHANCEMENT] Added FreeBSD support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a first implemetation for the FreeBSD support Signed-off-by: Vanja Cvelbar <b100w11@gmail.com>
AnomalRoil
reviewed
Sep 25, 2024
Comment on lines
+8
to
+11
| // "brave": "~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts", | ||
| // "vivaldi": "~/.config/vivaldi/NativeMessagingHosts", | ||
| "iridium": "~/.config/iridium/NativeMessagingHosts", | ||
| // "slimjet": "~/.config/slimjet/NativeMessagingHosts", |
There was a problem hiding this comment.
Why the commented out browsers?
There was a problem hiding this comment.
There is no support for those browsers in FreeBSD
There was a problem hiding this comment.
In that case please just remove them.
There was a problem hiding this comment.
In that case please just remove them.
Resolved in PR137
AnomalRoil
reviewed
Sep 25, 2024
Co-authored-by: AnomalRoil <AnomalRoil@users.noreply.github.com> Signed-off-by: Vanja Cvelbar <b100w11@gmail.com>
|
Just wondering if there's anything holding this PR up? I'm happy to help out in any way to get it moving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a first implemetation for the FreeBSD support