Merge pull request #134 from guillermodotn/master

Refactor TestValidBrowsers.
gopasspw · Oct 7, 2024 · e6f6c33 · e6f6c33
2 parents 7238fba + 242e197
commit e6f6c33
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/internal/jsonapi/manifest/setup_test.go b/internal/jsonapi/manifest/setup_test.go
@@ -50,12 +50,18 @@ func TestValidBrowser(t *testing.T) {
 func TestValidBrowsers(t *testing.T) {
 	t.Parallel()
 
-	validBrowsers := []string{"brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"}
-	if runtime.GOOS == "windows" {
+	var validBrowsers []string
+
+	switch runtime.GOOS {
+	case "darwin": // macOS
+		validBrowsers = []string{"arc", "brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"}
+	case "windows": // Windows
 		validBrowsers = []string{"chrome", "chromium", "firefox"}
+	case "linux": // Linux
+		validBrowsers = []string{"brave", "chrome", "chromium", "firefox", "iridium", "slimjet", "vivaldi"}
+	default: // Fallback, not suppoerted OS
+		t.Fatalf("Unsupported OS: %s", runtime.GOOS)
 	}
-	if runtime.GOOS == "darwin" {
-		validBrowsers = append(validBrowsers, "arc")
-	}
-	assert.ElementsMatch(t, validBrowsers, ValidBrowsers())
+
+	assert.Equal(t, validBrowsers, ValidBrowsers())
 }