Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky cram tests where vids leak into witnesses #1703

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

michael-schwarz
Copy link
Member

This works by canonizing the names such as alloc_m559918035_locked to TEMP_VAR1 and TEMP_VAR2. The bash script comes from deepseek, so it might make sense if someone who knows bash has a look (CC @DrMichaelPetter).

Closes #1647.

@michael-schwarz michael-schwarz requested a review from sim642 March 5, 2025 12:34
Copy link
Collaborator

@DrMichaelPetter DrMichaelPetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-schwarz
Copy link
Member Author

After @DrMichaelPetter's suggestions, I also used shellcheck (https://www.shellcheck.net/) and it is happy with the script too.

@sim642 sim642 added the bug label Mar 5, 2025
@sim642 sim642 added this to the v2.6.0 milestone Mar 5, 2025
@michael-schwarz michael-schwarz merged commit 50e8ab9 into master Mar 5, 2025
21 checks passed
@michael-schwarz michael-schwarz deleted the issue_1647 branch March 5, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cram tests not robust enough
3 participants