Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WA Polls: Create and manage polls #3185

Merged
merged 59 commits into from
Feb 19, 2025
Merged

WA Polls: Create and manage polls #3185

merged 59 commits into from
Feb 19, 2025

Conversation

akanshaaa19
Copy link
Member

target issue is #3177

@akanshaaa19 akanshaaa19 self-assigned this Jan 13, 2025
@akanshaaa19 akanshaaa19 linked an issue Jan 13, 2025 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Jan 13, 2025

@github-actions github-actions bot temporarily deployed to pull request January 13, 2025 04:44 Inactive
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 91.62562% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (6d381d2) to head (c247dd1).
Report is 60 commits behind head on master.

Files with missing lines Patch % Lines
...s/WaGroups/WaPolls/WaPollOptions/WaPollOptions.tsx 87.17% 0 Missing and 5 partials ⚠️
...iners/WaGroups/WaPolls/WaPollsList/WaPollsList.tsx 90.47% 2 Missing and 2 partials ⚠️
...atMessages/ChatMessage/PollMessage/PollMessage.tsx 83.33% 0 Missing and 3 partials ⚠️
src/containers/WaGroups/WaPolls/WaPolls.tsx 96.00% 0 Missing and 2 partials ⚠️
src/assets/images/icons/SideDrawer/WaPolls.tsx 50.00% 1 Missing ⚠️
src/components/simulator/Simulator.tsx 92.30% 1 Missing ⚠️
...ners/Chat/ChatMessages/ChatMessage/ChatMessage.tsx 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.01%     
==========================================
  Files         321      330       +9     
  Lines       10488    10679     +191     
  Branches     2181     2221      +40     
==========================================
+ Hits         8594     8750     +156     
- Misses       1274     1299      +25     
- Partials      620      630      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 13, 2025

Glific    Run #5585

Run Properties:  status check passed Passed #5585  •  git commit d028b6f284 ℹ️: Merge c247dd1ecfc7a5418722f69c5e616eddec4440b9 into 6d381d200ae2b5e7550e1329def3...
Project Glific
Branch Review feat/wa_polls
Run status status check passed Passed #5585
Run duration 25m 30s
Commit git commit d028b6f284 ℹ️: Merge c247dd1ecfc7a5418722f69c5e616eddec4440b9 into 6d381d200ae2b5e7550e1329def3...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request January 14, 2025 16:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 05:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 06:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 07:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 10:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 07:55 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund February 17, 2025 16:04
@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 23:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 18, 2025 04:01 Inactive
Simulator support for polls and subscription api
@github-actions github-actions bot temporarily deployed to pull request February 18, 2025 23:21 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

Can you please check and fix the failing tests.

@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 05:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 05:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 19, 2025 06:28 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund February 19, 2025 11:04
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurund kurund merged commit 9193bcf into master Feb 19, 2025
12 of 13 checks passed
@kurund kurund deleted the feat/wa_polls branch February 19, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wa Groups: Support to create and manage whatsapp polls
2 participants