momentjs/date-fns to dayjs #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2693 +/- ##
==========================================
- Coverage 72.85% 72.73% -0.13%
==========================================
Files 249 250 +1
Lines 8520 8592 +72
Branches 1808 1819 +11
==========================================
+ Hits 6207 6249 +42
- Misses 1705 1727 +22
- Partials 608 616 +8 ☔ View full report in Codecov by Sentry. |
3 failed and 3 flaky tests on run #3883 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Searches > should edit search |
Screenshots
|
|
setting/FlowSetting.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Organization Settings > should add default flow |
Screenshots
|
|
trigger/Trigger.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Triggers (daily) > should create new trigger |
Screenshots
|
|
flow/Flow.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Flow > should create duplicate Flow |
Screenshots
|
|
roles/staff/chat/Chat.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Role - Staff - Chats > should go to top |
Screenshots
|
|
staffmanagement/StaffManagement.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Staff Management > should delete collection |
Screenshots
|
|
Review all test suite changes for PR #2693 ↗︎
mdshamoon
requested changes
Jan 5, 2024
kurund
reviewed
Jan 5, 2024
kurund
reviewed
Jan 5, 2024
kurund
reviewed
Jan 5, 2024
kurund
reviewed
Jan 7, 2024
kurund
reviewed
Jan 7, 2024
src/common/constants.ts
Outdated
| @@ -112,8 +112,8 @@ export const setVariables = ( | |||
| }, | |||
| }); | |||
|
|
|||
| export const is24HourWindowOver = (time: any) => | |||
| moment.duration(moment(new Date()).diff(moment(time))).asHours() > 24; | |||
| export const is24HourWindowOver = (time: any) => | |||
mdshamoon
reviewed
Jan 10, 2024
src/containers/SettingList/OrganizationFlows/OrganisationFlows.tsx
Outdated
Show resolved
Hide resolved
mdshamoon
requested changes
Jan 10, 2024
mdshamoon
requested changes
Jan 11, 2024
Co-authored-by: Mohd Shamoon <32592458+mdshamoon@users.noreply.github.com>
Co-authored-by: Mohd Shamoon <32592458+mdshamoon@users.noreply.github.com>
mdshamoon
approved these changes
Jan 13, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated to dayjs from date-fns / momentjs as now it's a recommended option by MUI.
Check https://mui.com/x/react-date-pickers/#date-library
Datejs: https://day.js.org/
Test Plan