Use plain CSS to eliminate need for Sprockets and Sass building #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you'd be open to this change, but this tries to simplify usage of this gem with the evolving JS/CSS landscape. So while #92 made the sass compilation more flexible, this still wasn't compatible with certain setups (like vite_rails, since that doesn't use Sprockets), so this tries to simplify things further by eliminating the need for any type of specific asset pipeline solution.
While there might be various other approaches to this, since the CSS/JS dependencies in this app seem actually pretty straightforward, it seemed like the simplest approach might be to just inline the CSS into the default layout so there's no explicit dependencies. A similar gem, Maily, took this same inline approach: markets/maily#48. I also saw a comment from @rromanchuk in #92 with a somewhat similar fork to try and eliminate the need for Sass building steps.
Changes:
Applications using the gem could still have options for how to customize things, since apps should still be able to import the
application.css
orbootstrap.css
file into their own build process or Sass files. And similarly, custom layouts could still be used to tailor things further. I was just hoping this might provide an easier compatibility story for the gem out-of-the-box regardless of what asset solution the app is using.