Add dockerUrl in ClientAppMetadata

gizatechxyz · Oct 10, 2024 · 78b2712 · 78b2712
1 parent d7e48d0
commit 78b2712
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/contracts/script/DeployTaskAndAppRegistry.s.sol b/contracts/script/DeployTaskAndAppRegistry.s.sol
@@ -25,7 +25,8 @@ contract DeployTaskAndAppRegistry is Script, Constants {
             ClientAppMetadata({
                 name: "Ethereum Block Number",
                 description: "This task returns the current block number of the Ethereum network.",
-                logoUrl: ""
+                logoUrl: "",
+                dockerUrl: ""
             })
         );
 

diff --git a/contracts/src/ClientAppRegistry.sol b/contracts/src/ClientAppRegistry.sol
@@ -6,6 +6,7 @@ import {Ownable} from "./Ownable.sol";
 struct ClientAppMetadata {
     string name;
     string description;
+    string dockerUrl;
     string logoUrl;
 }
 

diff --git a/contracts/test/ClientAppRegistry.t.sol b/contracts/test/ClientAppRegistry.t.sol
@@ -15,6 +15,7 @@ contract ClientAppRegistryTest is TestState {
         ClientAppMetadata memory metadata = ClientAppMetadata({
             name: "Test App",
             description: "A test client application",
+            dockerUrl: "https://example.com/docker.png",
             logoUrl: "https://example.com/logo.png"
         });
 
@@ -27,13 +28,15 @@ contract ClientAppRegistryTest is TestState {
         assertEq(storedMetadata.name, metadata.name);
         assertEq(storedMetadata.description, metadata.description);
         assertEq(storedMetadata.logoUrl, metadata.logoUrl);
+        assertEq(storedMetadata.dockerUrl, metadata.dockerUrl);
     }
 
     function testRegisterClientApp_RevertWhen_NotOwner() public {
         bytes32 clientAppId = bytes32(uint256(1));
         ClientAppMetadata memory metadata = ClientAppMetadata({
             name: "Test App",
             description: "A test client application",
+            dockerUrl: "https://example.com/docker.png",
             logoUrl: "https://example.com/logo.png"
         });
 
@@ -47,6 +50,7 @@ contract ClientAppRegistryTest is TestState {
         ClientAppMetadata memory metadata = ClientAppMetadata({
             name: "Test App",
             description: "A test client application",
+            dockerUrl: "https://example.com/docker.png",
             logoUrl: "https://example.com/logo.png"
         });
 
@@ -63,6 +67,7 @@ contract ClientAppRegistryTest is TestState {
         ClientAppMetadata memory metadata = ClientAppMetadata({
             name: "Test App",
             description: "A test client application",
+            dockerUrl: "https://example.com/docker.png",
             logoUrl: "https://example.com/logo.png"
         });
 
@@ -73,13 +78,15 @@ contract ClientAppRegistryTest is TestState {
         assertEq(retrievedMetadata.name, metadata.name);
         assertEq(retrievedMetadata.description, metadata.description);
         assertEq(retrievedMetadata.logoUrl, metadata.logoUrl);
+        assertEq(retrievedMetadata.dockerUrl, metadata.dockerUrl);
     }
 
     function testIsClientApp() public {
         bytes32 clientAppId = bytes32(uint256(1));
         ClientAppMetadata memory metadata = ClientAppMetadata({
             name: "Test App",
             description: "A test client application",
+            dockerUrl: "https://example.com/docker.png",
             logoUrl: "https://example.com/logo.png"
         });
 

diff --git a/contracts/test/TaskRegistry.t.sol b/contracts/test/TaskRegistry.t.sol
@@ -13,7 +13,7 @@ contract TaskRegistryTest is TestState {
         // Register client app
         bytes32 appId = bytes32(uint256(1));
         vm.prank(owner);
-        clientAppRegistry.registerClientApp(appId, ClientAppMetadata("Test APP", "Test App", "TEST"));
+        clientAppRegistry.registerClientApp(appId, ClientAppMetadata("Test APP", "Test App", "TEST", ""));
     }
 
     function testSetAggregatorNode() public {