Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bool, int32, int64 in python bindings #178

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tehrengruber
Copy link
Contributor

No description provided.

@@ -0,0 +1,50 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really happy about the name and a new file. I'm open for suggestions, but also ok with this.

Comment on lines +37 to +40
if (cpp_name.empty()) {
throw std::invalid_argument("Unsupported numpy dtype");
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to handle the error at the call site (unless exceptions in C++ are commonly used in the bindings...)

@tehrengruber
Copy link
Contributor Author

The container images are out-dated.

@havogt
Copy link
Collaborator

havogt commented Jan 22, 2025

What do you mean by out-dated? Do you need a more recent compiler or is the image not compatible with the ubunut 24.04 runner?

@tehrengruber
Copy link
Contributor Author

tehrengruber commented Jan 22, 2025

GHEX uses container images that are not built by https://github.com/GridTools/gridtools-docker anymore. The gcc-9-ucx-mpi-atlas-parmetis-cuda-11 is easy to fix, not sure what about gcc-9-ucx-mpi-atlas-parmetis though. The issue is that those images don't use ubuntu 24.04, but 22.04. The pybind11 package that comes with that version is to old to provide item_type_is_equivalent_to which is used in this PR (pybind/pybind11@8e1f9d5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants