-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bool, int32, int64 in python bindings #178
base: master
Are you sure you want to change the base?
Add support for bool, int32, int64 in python bindings #178
Conversation
@@ -0,0 +1,50 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really happy about the name and a new file. I'm open for suggestions, but also ok with this.
if (cpp_name.empty()) { | ||
throw std::invalid_argument("Unsupported numpy dtype"); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to handle the error at the call site (unless exceptions in C++ are commonly used in the bindings...)
The container images are out-dated.
|
What do you mean by out-dated? Do you need a more recent compiler or is the image not compatible with the ubunut 24.04 runner? |
GHEX uses container images that are not built by https://github.com/GridTools/gridtools-docker anymore. The |
No description provided.