-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ensure Correct Column (npde_mode_simBlq vs. npde_simBlq) is Used for sim_blq=TRUE in Plotting Functions #381
base: develop
Are you sure you want to change the base?
Conversation
…ensuring the correct data is used for plots when sim_blq=TRUE
I think that
|
…d blq data for npde
Hello @A2P2, I encountered an issue while trying to push a large .zip file to the repository. The file exceeds GitHub's file size limit of 100 MB, and I am using Git LFS to manage large files. However, I am unable to upload new objects to my public fork of the repository due to restrictions on public forks related to Git LFS. As a result, I am unable to push the file directly to the repository. I will explore alternative ways to share this file but if there are any suggestions or solutions, please let me know. |
@certara-irebai Hi Ibtissem, thank you for the pull request. Could you explain how you got 100 MB archive from the hiv model? I get it under 1MB, but maybe I'm not archiving the right files. Is it vpc files from simulx? |
@A2P2 Hi Alex, I didn't apply a filter to the data and saved all the Monilix result folders so that's why the file was heavy. I have deleted some useless folders and managed to share the folder. Please let me know if it works. Thanks |
Looks good and works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks good to me; I do have a few questions captured in my review.
In general if there are different types of simBlq
captured in the output dataset, should an option be provided to import the one the user wants? (with the default being then one we already select in this code).
Other than that looks good to me 😄
col_name_mode <- paste0(cn, "_mode_simBlq") # e.g., npde_mode_simBlq | ||
col_name_simple <- paste0(cn, "_simBlq") # e.g., npde_simBlq | ||
|
||
# If the "_mode_simBlq" column exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the _mode_simBlq
column exists, is there a _mean_simBlq
or other sort of column. In some cases, the endpoint is also part of the variable name; do we know if that is the case here?
adds a check to select between xx_mode_simBlq and xx_simBlq columns, ensuring the correct data is used for plots when sim_blq=TRUE