Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure Correct Column (npde_mode_simBlq vs. npde_simBlq) is Used for sim_blq=TRUE in Plotting Functions #381

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

certara-irebai
Copy link

adds a check to select between xx_mode_simBlq and xx_simBlq columns, ensuring the correct data is used for plots when sim_blq=TRUE

…ensuring the correct data is used for plots when sim_blq=TRUE
@A2P2
Copy link
Collaborator

A2P2 commented Nov 22, 2024

Hi @certara-irebai

I think that hiv_project.mlxtran from Monolix demo case studies can be used for a test here. Let me know if it works. runScenario() takes ~10 minutes with the whole dataset, you might want to apply a filter on the dataset.

library(ggPMX)
library(lixoftConnectors)
library(here)
initializeLixoftConnectors()


##Load project and save charts data
path <- here(getDemoPath(), '8.case_studies', 'hiv_project.mlxtran')
loadProject(path)
#createFilter(filter = list(list(selectIds = "ID<10"))) #optionally to improve the runtime
runScenario()
saveProject()

ctr = pmx_mlxtran(file_name = path, endpoint  = c(1, 2))

#works
ctr%>%pmx_plot_iwres_time(sim_blq = TRUE)
ctr%>%pmx_plot_iwres_time()

#doesn't work
ctr%>%pmx_plot_npde_pred(sim_blq = TRUE)
ctr%>%pmx_plot_npde_pred()

@A2P2 A2P2 self-requested a review November 22, 2024 11:16
@certara-irebai
Copy link
Author

Hello @A2P2,

I encountered an issue while trying to push a large .zip file to the repository. The file exceeds GitHub's file size limit of 100 MB, and I am using Git LFS to manage large files. However, I am unable to upload new objects to my public fork of the repository due to restrictions on public forks related to Git LFS.

As a result, I am unable to push the file directly to the repository. I will explore alternative ways to share this file but if there are any suggestions or solutions, please let me know.

@A2P2
Copy link
Collaborator

A2P2 commented Jan 9, 2025

@certara-irebai Hi Ibtissem, thank you for the pull request. Could you explain how you got 100 MB archive from the hiv model? I get it under 1MB, but maybe I'm not archiving the right files. Is it vpc files from simulx?

@certara-irebai
Copy link
Author

@A2P2 Hi Alex, I didn't apply a filter to the data and saved all the Monilix result folders so that's why the file was heavy. I have deleted some useless folders and managed to share the folder. Please let me know if it works. Thanks

@A2P2 A2P2 changed the base branch from master to develop January 14, 2025 12:06
@A2P2
Copy link
Collaborator

A2P2 commented Jan 14, 2025

Looks good and works for me.
@mattfidler do you have any comments?

Copy link
Collaborator

@mattfidler mattfidler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me; I do have a few questions captured in my review.

In general if there are different types of simBlq captured in the output dataset, should an option be provided to import the one the user wants? (with the default being then one we already select in this code).

Other than that looks good to me 😄

col_name_mode <- paste0(cn, "_mode_simBlq") # e.g., npde_mode_simBlq
col_name_simple <- paste0(cn, "_simBlq") # e.g., npde_simBlq

# If the "_mode_simBlq" column exists
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the _mode_simBlq column exists, is there a _mean_simBlq or other sort of column. In some cases, the endpoint is also part of the variable name; do we know if that is the case here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants