fix(demangle): Suppresses c++ warnings on older GCCs #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Jan 9, 2025
Dav1dde
force-pushed
the
dav1d/fix-demangle-build
branch
from
a53ed9e to
3fa6035
Compare
Dav1dde
force-pushed
the
dav1d/fix-demangle-build
branch
from
3fa6035 to
05a5532
Compare
jjbayer
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older GCC versions do not have
-Wno-changes-meaningas a separate warning, but it is part of the permissive category.Also removes the mac os min, it's not actually required as I thought before it was.