Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(debuginfo): Replace dmsort with std sort #869

Merged
merged 7 commits into from
Sep 17, 2024
Merged

ref(debuginfo): Replace dmsort with std sort #869

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5892ce0
fix(tests): Fix test snapshots for 1.81
loewenheim Sep 17, 2024
f62903d
Another one
loewenheim Sep 17, 2024
11c810d
Remove dmsort
loewenheim Sep 17, 2024
0b735bb
Snapshot
loewenheim Sep 17, 2024
9a0bca0
Use stable sort
loewenheim Sep 17, 2024
8772cfd
Forgot snapshot
loewenheim Sep 17, 2024
4b62e9e
Changelog
loewenheim Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions symbolic-debuginfo/tests/snapshots/test_objects__elf_symbols.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-02-27T13:05:25.490529Z"
creator: insta@0.6.3
source: debuginfo/tests/test_objects.rs
source: symbolic-debuginfo/tests/test_objects.rs
expression: SymbolsDebug(&symbols)
---
1558 _init
Expand Down Expand Up @@ -41,7 +39,7 @@ expression: SymbolsDebug(&symbols)
3660 _ZN15google_breakpad30SetFirstChanceExceptionHandlerEPFbiPvS0_E
3670 _ZN15google_breakpad16ExceptionHandlerC1ERKNS_18MinidumpDescriptorEPFbPvEPFbS3_S4_bES4_bi
3a10 _ZN15google_breakpad16ExceptionHandler13WriteMinidumpERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEPFbRKNS_18MinidumpDescriptorEPvbESC_
3cb0 _ZNSt6vectorIPN15google_breakpad16ExceptionHandlerESaIS2_EE19_M_emplace_back_auxIIS2_EEEvDpOT_
3cb0 _ZNSt6vectorIPN15google_breakpad16ExceptionHandlerESaIS2_EE19_M_emplace_back_auxIJS2_EEEvDpOT_
3da0 _ZN15google_breakpad18MinidumpDescriptorC1ERKS0_
3f20 _ZN15google_breakpad18MinidumpDescriptor10UpdatePathEv
42f0 _ZN15google_breakpad18MinidumpDescriptoraSERKS0_
Expand Down Expand Up @@ -71,9 +69,9 @@ expression: SymbolsDebug(&symbols)
94a0 _ZNK15google_breakpad17LinuxPtraceDumper12IsPostMortemEv
94b0 _ZN15google_breakpad17LinuxPtraceDumper15CopyFromProcessEPviPKvm
9640 _ZN15google_breakpad17LinuxPtraceDumper13ThreadsResumeEv
9700 _ZNK15google_breakpad17LinuxPtraceDumper13BuildProcPathEPciPKc
9700 _ZNK15google_breakpad17LinuxPtraceDumper13BuildProcPathEPciPKc.localalias.19
97c0 _ZN15google_breakpad17LinuxPtraceDumper16EnumerateThreadsEv
9e50 _ZN15google_breakpad17LinuxPtraceDumperC1Ei
9e50 _ZN15google_breakpad17LinuxPtraceDumperC2Ei
9e80 _ZN15google_breakpad17LinuxPtraceDumper15ReadRegisterSetEPNS_10ThreadInfoEi
9f70 _ZN15google_breakpad17LinuxPtraceDumper13ReadRegistersEPNS_10ThreadInfoEi
a050 _ZN15google_breakpad17LinuxPtraceDumper20GetThreadInfoByIndexEmPNS_10ThreadInfoE
Expand All @@ -94,7 +92,7 @@ expression: SymbolsDebug(&symbols)
f3c0 _ZN15google_breakpad13WriteMinidumpEiliPKvmRKNSt7__cxx114listINS_12MappingEntryESaIS4_EEERKNS3_INS_9AppMemoryESaIS9_EEEbmb
f400 _ZN15google_breakpad17ProcCpuInfoReader12GetNextFieldEPPKc
f660 _ZNSt6vectorIcN15google_breakpad16PageStdAllocatorIcEEE6resizeEm
f8c0 _ZNSt6vectorI18MDMemoryDescriptorN15google_breakpad16PageStdAllocatorIS0_EEE19_M_emplace_back_auxIIRKS0_EEEvDpOT_
f8c0 _ZNSt6vectorI18MDMemoryDescriptorN15google_breakpad16PageStdAllocatorIS0_EEE19_M_emplace_back_auxIJRKS0_EEEvDpOT_
fb10 _ZN15google_breakpad10TypedMDRVAI8MDStringE20CopyIndexAfterObjectEjPKvm.isra.7.part.8
fb40 _ZN15google_breakpad18MinidumpFileWriterC1Ev
fb60 _ZN15google_breakpad18MinidumpFileWriter4OpenEPKc
Expand All @@ -120,8 +118,8 @@ expression: SymbolsDebug(&symbols)
11220 _ZN15google_breakpad8ElfClassEPKv
11230 _ZN15google_breakpad14FindElfSectionEPKvPKcjPS1_Pm
116a0 _ZN15google_breakpad15FindElfSegmentsEPKvjPNS_15wasteful_vectorINS_10ElfSegmentEEE
11990 _ZNSt6vectorIN15google_breakpad10ElfSegmentENS0_16PageStdAllocatorIS1_EEE19_M_emplace_back_auxIIRKS1_EEEvDpOT_
11be0 _ZN15google_breakpad6FileIDC2EPKc
11990 _ZNSt6vectorIN15google_breakpad10ElfSegmentENS0_16PageStdAllocatorIS1_EEE19_M_emplace_back_auxIJRKS1_EEEvDpOT_
11be0 _ZN15google_breakpad6FileIDC1EPKc
11cc0 _ZN15google_breakpad6FileID29ConvertIdentifierToUUIDStringB5cxx11ERKNS_15wasteful_vectorIhEE
11e70 _ZN15google_breakpad6FileID25ConvertIdentifierToStringB5cxx11ERKNS_15wasteful_vectorIhEE
11fb0 _ZN15google_breakpad6FileID31ElfFileIdentifierFromMappedFileEPKvRNS_15wasteful_vectorIhEE
Expand All @@ -148,9 +146,9 @@ expression: SymbolsDebug(&symbols)
13220 _ZN15google_breakpad16MemoryMappedFile5UnmapEv
13270 _ZN15google_breakpad16MemoryMappedFileD2Ev
13280 _ZN15google_breakpad16MemoryMappedFile3MapEPKcm
13430 _ZN15google_breakpad16MemoryMappedFileC1EPKcm
13430 _ZN15google_breakpad16MemoryMappedFileC2EPKcm
13450 _ZN15google_breakpad12SafeReadLinkEPKcPcm
13490 _ZN15google_breakpad12_GLOBAL__N_125CrashGenerationClientImplD1Ev
13490 _ZN15google_breakpad12_GLOBAL__N_125CrashGenerationClientImplD2Ev
134a0 _ZN15google_breakpad12_GLOBAL__N_125CrashGenerationClientImpl11RequestDumpEPKvm
136c0 _ZN15google_breakpad12_GLOBAL__N_125CrashGenerationClientImplD0Ev
136d0 _ZN15google_breakpad21CrashGenerationClient9TryCreateEi
Expand All @@ -171,4 +169,3 @@ expression: SymbolsDebug(&symbols)
14c30 __libc_csu_init
14ca0 __libc_csu_fini
14ca4 _fini

7 changes: 3 additions & 4 deletions symbolic-debuginfo/tests/snapshots/test_objects__pdb_symbols.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ expression: SymbolsDebug(&symbols)
2e72 ??0bad_array_new_length@std@@QAE@XZ
2e8a ??0exception@std@@QAE@ABV01@@Z
2eb6 ??1bad_alloc@std@@UAE@XZ
2ec7 ??_Eexception@std@@UAEPAXI@Z
2ec7 ??_Gexception@std@@UAEPAXI@Z
2ef4 ?__scrt_throw_std_bad_alloc@@YAXXZ
2f11 ?__scrt_throw_std_bad_array_new_length@@YAXXZ
2f2e ?what@exception@std@@UBEPBDXZ
Expand All @@ -65,9 +65,9 @@ expression: SymbolsDebug(&symbols)
3253 __get_startup_argv_mode
3257 __get_startup_file_mode
325d ?__scrt_initialize_type_info@@YAXXZ
3269 ___vcrt_uninitialize
3269 __should_initialize_environment
326c __initialize_default_precision
328d @_guard_check_icall_nop@4
328d __initialize_denormal_control
328e ___local_stdio_scanf_options
3294 ___scrt_initialize_default_local_stdio_options
32b1 ___scrt_is_user_matherr_present
Expand Down Expand Up @@ -122,4 +122,3 @@ expression: SymbolsDebug(&symbols)
37e6 _terminate
37ec _IsProcessorFeaturePresent@4
37f2 _memcpy

Loading