Support reading (ET_SCE_DYNEXEC,ET_SCE_DYNAMIC) DebugId and Object Kind #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 74.99% 74.96% -0.04%
==========================================
Files 71 71
Lines 15561 15568 +7
==========================================
Hits 11670 11670
- Misses 3891 3898 +7 |
loewenheim
reviewed
Apr 14, 2023
| const PT_SCE_DYNLIBDATA: u32 = 0x61000000; | ||
|
|
||
| for ph in &self.elf.program_headers { | ||
| if ph.p_type == PT_SCE_DYNLIBDATA && ph.p_filesz >= 20 { |
There was a problem hiding this comment.
What's the significance of 20 here?
There was a problem hiding this comment.
From what information I can find on the public web, this section starts with a 24 byte signature, but normal build ids are only 20 bytes. In the files I am looking at, we actually have 16 usable bytes, with 4 null-bytes afterwards.
loewenheim
approved these changes
Apr 14, 2023
bruno-garcia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog