-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run codecov on demand after test workflows are done #2562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
=======================================
Coverage 64.11% 64.12%
=======================================
Files 123 123
Lines 4724 4689 -35
=======================================
- Hits 3029 3007 -22
+ Misses 1695 1682 -13
|
we actually want to submit coverage for all builds to get more accurate results. Codecov does something called Merging Reports and once all builds pass the coverage is accurate. We had single run coverage before and that was far less accurate than what we have now. |
if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
steps: | ||
- name: Codecov | ||
uses: codecov/codecov-action@v5.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hate this bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's what I just thought 🤣
b10dece
to
0efeb0c
Compare
@sl0thentr0py right I forgot about this, sorry. I removed this change and added a new codecov.yml that runs after test workflows are done, I reckon that was our issue - it would trigger notification while tests were still running and submitting coverage. |
0efeb0c
to
94a10bc
Compare
Run codecov on demand after test workflows are done.
#skip-changelog