Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run codecov on demand after test workflows are done #2562

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Feb 18, 2025

Run codecov on demand after test workflows are done.

#skip-changelog

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (db975df) to head (94a10bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2562   +/-   ##
=======================================
  Coverage   64.11%   64.12%           
=======================================
  Files         123      123           
  Lines        4724     4689   -35     
=======================================
- Hits         3029     3007   -22     
+ Misses       1695     1682   -13     
Components Coverage Δ
sentry-ruby 59.73% <ø> (-0.12%) ⬇️
sentry-rails 60.83% <ø> (+1.61%) ⬆️
sentry-sidekiq 95.52% <ø> (-1.64%) ⬇️
sentry-resque 92.42% <ø> (-0.44%) ⬇️
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (+0.68%) ⬆️

see 30 files with indirect coverage changes

@sl0thentr0py
Copy link
Member

we actually want to submit coverage for all builds to get more accurate results. Codecov does something called Merging Reports and once all builds pass the coverage is accurate.

We had single run coverage before and that was far less accurate than what we have now.

@solnic solnic marked this pull request as draft February 18, 2025 13:45
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- name: Codecov
uses: codecov/codecov-action@v5.3.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate this bot

Copy link
Collaborator Author

@solnic solnic Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's what I just thought 🤣

@solnic solnic force-pushed the solnic/fix-codecov-submissions branch from b10dece to 0efeb0c Compare February 18, 2025 13:46
@solnic solnic marked this pull request as ready for review February 18, 2025 13:57
@solnic solnic changed the title Submit coverage only once for latest ruby in matrix Run codecov on demand after test workflows are done Feb 18, 2025
@solnic
Copy link
Collaborator Author

solnic commented Feb 18, 2025

we actually want to submit coverage for all builds to get more accurate results. Codecov does something called Merging Reports and once all builds pass the coverage is accurate.

@sl0thentr0py right I forgot about this, sorry. I removed this change and added a new codecov.yml that runs after test workflows are done, I reckon that was our issue - it would trigger notification while tests were still running and submitting coverage.

@solnic solnic force-pushed the solnic/fix-codecov-submissions branch from 0efeb0c to 94a10bc Compare February 18, 2025 14:03
@solnic solnic merged commit ffd993a into master Feb 18, 2025
145 of 148 checks passed
@solnic solnic deleted the solnic/fix-codecov-submissions branch February 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants