Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct breadcrumb levels for 4xx/5xx response codes #2549

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

sl0thentr0py
Copy link
Member

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (cfd5059) to head (0711de3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/utils/http_tracing.rb 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
+ Coverage   67.90%   69.70%   +1.80%     
==========================================
  Files         118      126       +8     
  Lines        4483     4737     +254     
==========================================
+ Hits         3044     3302     +258     
+ Misses       1439     1435       -4     
Components Coverage Δ
sentry-ruby 60.63% <25.00%> (+0.51%) ⬆️
sentry-rails 97.48% <ø> (ø)
sentry-sidekiq 95.52% <ø> (∅)
sentry-resque 92.64% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/utils/http_tracing.rb 28.20% <25.00%> (-0.83%) ⬇️

... and 12 files with indirect coverage changes

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions, otherwise LGTM

sl0thentr0py and others added 2 commits February 7, 2025 13:35
Co-authored-by: Peter Solnica <peter@solnica.online>
Co-authored-by: Peter Solnica <peter@solnica.online>
@sl0thentr0py sl0thentr0py force-pushed the neel/fix-breadcrumb-http-levels branch from cc18db7 to 0711de3 Compare February 7, 2025 12:41
@sl0thentr0py sl0thentr0py merged commit 1fb93ad into master Feb 7, 2025
136 of 137 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-breadcrumb-http-levels branch February 7, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants