Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with CheckInEvent in before_send #2541

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

sl0thentr0py
Copy link
Member

closes #2540

@sl0thentr0py sl0thentr0py requested a review from st0012 February 5, 2025 11:07
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (b5a4948) to head (d068d34).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2541      +/-   ##
==========================================
- Coverage   69.40%   69.39%   -0.01%     
==========================================
  Files         126      126              
  Lines        4723     4725       +2     
==========================================
+ Hits         3278     3279       +1     
- Misses       1445     1446       +1     
Components Coverage Δ
sentry-ruby 60.19% <ø> (ø)
sentry-rails 97.48% <ø> (ø)
sentry-sidekiq 95.52% <ø> (-0.38%) ⬇️
sentry-resque 92.64% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/client.rb 48.52% <ø> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/check-in-before-send-regression branch from ebab5d9 to d068d34 Compare February 5, 2025 11:09
@sl0thentr0py sl0thentr0py merged commit 94d302a into master Feb 5, 2025
133 of 147 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/check-in-before-send-regression branch February 5, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry::CheckInEvent discarded because before_send didn't return a Sentry::ErrorEvent
2 participants