Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add report_after_job_retries support for ActiveJob #2500

Closed

try a different way

f8a24b2
Select commit
Loading
Failed to load commit list.
Closed

add report_after_job_retries support for ActiveJob #2500

try a different way
f8a24b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 13, 2025 in 0s

96.99% (-1.18%) compared to a1d2941

View this Pull Request on Codecov

96.99% (-1.18%) compared to a1d2941

Details

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (a1d2941) to head (f8a24b2).

Files with missing lines Patch % Lines
sentry-rails/lib/sentry/rails/active_job.rb 53.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   98.16%   96.99%   -1.18%     
==========================================
  Files         128      126       -2     
  Lines        4847     4787      -60     
==========================================
- Hits         4758     4643     -115     
- Misses         89      144      +55     
Components Coverage Δ
sentry-ruby 98.57% <ø> (ø)
sentry-rails 87.26% <65.00%> (-9.81%) ⬇️
sentry-sidekiq 97.09% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (+0.68%) ⬆️
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/configuration.rb 95.45% <100.00%> (-4.55%) ⬇️
sentry-rails/lib/sentry/rails/railtie.rb 87.95% <100.00%> (-10.80%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 87.71% <53.33%> (-12.29%) ⬇️

... and 10 files with indirect coverage changes