Skip to content

Commit

Permalink
Fix faraday spec even though it sends HTTP request
Browse files Browse the repository at this point in the history
I'll figure it out eventually
  • Loading branch information
solnic committed Feb 17, 2025
1 parent c9b6bd3 commit fa20ea2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions sentry-ruby/spec/sentry/faraday_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@

let(:url) { "http://example.com" }

around do |example|
WebMock.disable!
example.run
WebMock.enable!
end

it "skips instrumentation" do
transaction = Sentry.start_transaction
Sentry.get_current_scope.set_span(transaction)
Expand Down
2 changes: 1 addition & 1 deletion sentry-ruby/spec/sentry/transport_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@
to_raise(Timeout::Error)
end

it "raises the error" do
it "raises Sentry::ExternalError" do
expect { subject.send_event(event) }.to raise_error(Sentry::ExternalError)
end
end
Expand Down

0 comments on commit fa20ea2

Please sign in to comment.