Skip to content

Commit

Permalink
Fix warning about default gems on Ruby 3.3.0 (#2225)
Browse files Browse the repository at this point in the history
* Add `bigdecimal` to the gemspec

Since Ruby 3.3.0, RubyGems and Bundler warn if users do require the
gems that will become the bundled gems in the future version of Ruby.

Please see the "Standard library updates" section for the details.
https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/

`sentry-ruby` uses one of those gems, `bigdecimal`.
So now get the warning like the following.
https://github.com/getsentry/sentry-ruby/actions/runs/7463068254/job/20306920751#step:6:89

This PR adds `bigdecimal` to the gemspec to fix the warning.

* Remove unsued require

Base64 has unused since 46384cd.
  • Loading branch information
y-yagi authored Jan 13, 2024
1 parent bf13c7e commit d408bdd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Fix warning about default gems on Ruby 3.3.0 ([#2225](https://github.com/getsentry/sentry-ruby/pull/2225))

## 5.16.1

### Bug Fixes
Expand Down
1 change: 0 additions & 1 deletion sentry-ruby/lib/sentry/transport.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# frozen_string_literal: true

require "json"
require "base64"
require "sentry/envelope"

module Sentry
Expand Down
1 change: 1 addition & 0 deletions sentry-ruby/sentry-ruby.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "concurrent-ruby", '~> 1.0', '>= 1.0.2'
spec.add_dependency "bigdecimal"
end

0 comments on commit d408bdd

Please sign in to comment.