-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(relay): Update axum-extra and otel-proto libs #3798
Conversation
"startTimeUnixNano": "1697620454980000000", | ||
"endTimeUnixNano": "1697620454980078800", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we still be able to parse long integers? Even if they get serialized as strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? Even if they get serialized as strings?
-> They are serialized as a string and that works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline: This will break the OTLP endpoint for old clients that send these values as numbers. We're OK with this breakage because the endpoint is experimental and gated behind a feature flag.
"startTimeUnixNano": "1697620454980000000", | ||
"endTimeUnixNano": "1697620454980078800", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline: This will break the OTLP endpoint for old clients that send these values as numbers. We're OK with this breakage because the endpoint is experimental and gated behind a feature flag.
The Rust dependency is now incompatible with the python lib with the same name, protobuf payloads with integers as attributes fail to parse. |
Upstream issue for this: open-telemetry/opentelemetry-rust#1905 |
With the changes from here (open-telemetry/opentelemetry-rust#1753), integers are strings now ...
axum-extra update is required for prost 0.12 which is required for the otel dependency.
#skip-changelog