Add deb822 format for repository source file #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I upgraded a series of VMs from Ubuntu 22.04 to 24.04; Docker had been installed on all of them using this role.
After completing the upgrade, I noticed that the
/etc/apt/sources.list.d/directory contained the filedocker.list.distUpgrade, which was created from the olddocker.list(added by the role), along withdocker.sources, a deb822-formatted file that was automatically generated.When I tried rerunning the role, the
docker.listfile was recreated, and on the firstapt update, many warnings appeared because there were two files referencing the same repository:Since the
deb822format is already used with Ubuntu 24.04 and the one-line format will be deprecated in the future, would it be possible to introduce it within the role?I have prepared this PR for this purpose. Let me know if any changes are needed.