Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui.cc: return "" instead of nullptr #2819

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes return values in a function

Summary

The defaultGuiConfigFile function returns type std::string, so return an empty string instead of nullptr in error cases.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The defaultGuiConfigFile function returns type
std::string, so return an empty string instead of
nullptr in error cases.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from jennuine as a code owner March 12, 2025 03:12
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 12, 2025
@arjo129 arjo129 enabled auto-merge (squash) March 12, 2025 03:20
@arjo129 arjo129 merged commit e47b0d4 into gz-sim8 Mar 12, 2025
11 checks passed
@arjo129 arjo129 deleted the scpeters/gui_cc_fix_return_type branch March 12, 2025 04:20
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.85%. Comparing base (ab18888) to head (aa76af0).
Report is 150 commits behind head on gz-sim8.

Files with missing lines Patch % Lines
src/gui/Gui.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2819      +/-   ##
===========================================
+ Coverage    65.75%   68.85%   +3.09%     
===========================================
  Files          327      340      +13     
  Lines        31233    33011    +1778     
===========================================
+ Hits         20537    22729    +2192     
+ Misses       10696    10282     -414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants