-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LogicalCamera plugin to detect nested models #2788
Merged
iche033
merged 3 commits into
gazebosim:gz-sim9
from
Dyst-0:logical-camera-detect-nested-models-feature
Feb 22, 2025
Merged
Update LogicalCamera plugin to detect nested models #2788
iche033
merged 3 commits into
gazebosim:gz-sim9
from
Dyst-0:logical-camera-detect-nested-models-feature
Feb 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
iche033
approved these changes
Feb 21, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 Can we backport this to |
@Mergifyio backport gz-sim9 |
✅ Backports have been created
|
@Mergifyio backport gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 036515f)
9 tasks
ahcorde
pushed a commit
that referenced
this pull request
Feb 27, 2025
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 036515f) Co-authored-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #2786
Summary
Logical camera now detects nested models instead of top level models only.
Test it
1 - Nest a model inside
box
inlogical_camera_sensor.sdf
Nested model example
2 - Build and source if needed
3 - Run
gz sim logical_camera_sensor.sdf
4 - Run
gz topic -e -t /logical_camera
The output should show information about
nested_model
and the top level modelbox
Example output
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.