Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings generated by NetworkConfigTest #2469

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix warnings generated by NetworkConfigTest #2469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/network/NetworkConfig_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*
*/


#include <gtest/gtest.h>

#include <gz/common/Console.hh>
Expand All @@ -30,38 +31,33 @@ TEST(NetworkManager, ValueConstructor)
{
// Primary without number of secondaries is invalid
auto config = NetworkConfig::FromValues("PRIMARY", 0);
assert(config.role == NetworkRole::None);
assert(config.numSecondariesExpected == 0);
ASSERT_EQ(config.role, NetworkRole::None);
ASSERT_EQ(config.numSecondariesExpected, 0);
// Expect console warning as well
(void) config;
}

{
// Primary with number of secondaries is valid
auto config = NetworkConfig::FromValues("PRIMARY", 3);
assert(config.role == NetworkRole::SimulationPrimary);
assert(config.numSecondariesExpected == 3);
(void) config;
ASSERT_EQ(config.role, NetworkRole::SimulationPrimary);
ASSERT_EQ(config.numSecondariesExpected, 3);
}

{
// Secondary is always valid
auto config = NetworkConfig::FromValues("SECONDARY", 0);
assert(config.role == NetworkRole::SimulationSecondary);
(void) config;
ASSERT_EQ(config.role, NetworkRole::SimulationSecondary);
}

{
// Readonly is always valid
auto config = NetworkConfig::FromValues("READONLY");
assert(config.role == NetworkRole::ReadOnly);
(void) config;
ASSERT_EQ(config.role, NetworkRole::ReadOnly);
}

{
// Anything else is invalid
auto config = NetworkConfig::FromValues("READ_WRITE");
assert(config.role == NetworkRole::None);
(void) config;
ASSERT_EQ(config.role, NetworkRole::None);
}
}
Loading