Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of reset_sensors test #2467

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 8, 2024

🦟 Bug fix

Fixes comments describing a test

Summary

I noticed that the INTEGRATION_reset_sensors test is failing in #2232, and while reading through the test I noticed that the test description doesn't seem to match what the test is doing and appears to be copied from test/integration/sensors_system.cc. This updates the comment with my understanding of what the test appears to do.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner July 8, 2024 17:22
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 8, 2024
@scpeters scpeters merged commit 924607b into gz-sim8 Jul 8, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/reset_sensors_description branch July 8, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants