Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-releases for gz-sim8 to test gz-transport 13.2.0 #82

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 25, 2024

No description provided.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@j-rivero
Copy link
Contributor

Out of curiosity and for future developments: what is the use case that requires to modify the yaml file here? To get green CI on Jenkins? To test a -ci-pr_any- manual build? Other?

@iche033
Copy link
Contributor Author

iche033 commented Mar 25, 2024

after this PR is merged, my use case is to trigger a build in https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-jammy-amd64/ (which has started failing recently) to see we can get green CI back on Jenkins.

@iche033 iche033 merged commit 8f7e2d1 into master Mar 25, 2024
3 checks passed
@iche033 iche033 deleted the gzsim8_prerelease branch March 25, 2024 22:05
@j-rivero
Copy link
Contributor

after this PR is merged, my use case is to trigger a build in https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-jammy-amd64/ (which has started failing recently) to see we can get green CI back on Jenkins.

I see. My point here is what we need to modify to avoid setting this permanent change and allow this kind of change. My initial thought was to add a REPOS_TO_USE to https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64 but that will change all packages to use the prerelease repository.

We can add a GZDEV_BRANCH to the -ci-pr_any- jobs so you can modify this repository in a branch and test a job directly from there without modifying the permanent configuration of all jobs.

@iche033
Copy link
Contributor Author

iche033 commented Mar 26, 2024

We can add a GZDEV_BRANCH to the -ci-pr_any- jobs so you can modify this repository in a branch and test a job directly from there without modifying the permanent configuration of all jobs.

yep that sounds like a good idea to avoid changing and reverting changes in this file after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants