Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install colcon and vcs from packages #79

Open
wants to merge 7 commits into
base: noble
Choose a base branch
from
Open

Install colcon and vcs from packages #79

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebcbb7e
Allow pip to install on the system
j-rivero Feb 5, 2024
31431e8
Install colcon and vcs from packages. Avoid pip
j-rivero Jul 30, 2024
c726928
Bad merge
j-rivero Jul 30, 2024
938780a
Merge branch 'noble' into jrivero/vcs_colcon
j-rivero Jul 30, 2024
b994b2e
Relocate colcon + vcs
j-rivero Jul 30, 2024
0b5fb1d
Duplicate vcs-tools
j-rivero Jul 30, 2024
8ad5f59
Import packagecloud repositories for vcstool and colcon
j-rivero Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,18 @@ pip3 install -r /tmp/gzdev/requirements.txt --break-system-packages
apt-get update 2>&1
echo ::endgroup::

echo ::group::Install tools: pip
pip3 install -U vcstool colcon-common-extensions --break-system-packages
echo ::endgroup::

if [ -f "$SOURCE_DEPENDENCIES" ] || [ -f "$SOURCE_DEPENDENCIES_VERSIONED" ] ; then
echo ::group::Prepare colcon and vcs for source dependencies
# Add colcon repository
mkdir -p /etc/apt/keyrings/
for tool in colcon vcstool; do
curl -fsSL "https://packagecloud.io/dirk-thomas/${tool}/gpgkey" | gpg --dearmor > "/etc/apt/keyrings/${tool}-archive-keyring.gpg"
echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/${tool}-archive-keyring.gpg] https://packagecloud.io/dirk-thomas/${tool}/ubuntu $(. /etc/os-release && echo $UBUNTU_CODENAME) main" | sudo tee /etc/apt/sources.list.d/${tool}.list > /dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that vcstool is coming from a third-party repo as well. This probably what we want since the one in Ubuntu upstream is usually outdated, but the statement in the PR description mentions that we're using the one from upstream, so I was a little confused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR description

done
apt update 2>&1
apt -y install python3-vcstool \
python3-colcon-common-extensions
echo ::endgroup::
echo ::group::Fetch source dependencies
mkdir -p deps/src
if [ -f "$SOURCE_DEPENDENCIES" ] ; then
Expand Down