bug: not all true types can use winansiencoding. need to check cmaps #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galkahana
deleted the
galk.true_type_bad_cmap_bug.check_cmaps_to_use_winansiencoding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #255.
In order to use winansiencoding (or in other words...non cid encoding) for true type fonts, the embedded font program must contain a method to translate the winansiencoding glyph names to glyph ids. For this to happen, there should be either 3,1 cmap encoding existing (win unicode bmp) or 1,0 cmap (mac roman). helveticaneue, for instance, does not have this table and so the library should not attempt to build a winansiencoding representation, but go straight to cid. arial.ttf does have the right cmaps and so can use it.