Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync project version and use dynamic version #49

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Nov 26, 2024

Currently:

  • Check Release / check_release CI job is failing due to static version in toml file
  • package.json and python package versions were out of sync

This PR:

  • We can use the dynamic version and it is pulled into package.json with hatch (or manually modifying the package.json) and that dynamically resolves the python package version. as well.

@RRosio RRosio added the maintenance General tasks for project upkeep label Nov 26, 2024
@RRosio
Copy link
Collaborator Author

RRosio commented Nov 26, 2024

  • CI is green and the CI build job's Extension artifact installs without issues

@RRosio RRosio merged commit 8819e44 into fsspec:main Nov 26, 2024
8 checks passed
@RRosio RRosio deleted the sync_version branch November 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General tasks for project upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant