accept "default" as "ok response" fallback #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would be also nice to add your schema to test schemas - https://github.com/fsprojects/SwaggerProvider/tree/master/tests/SwaggerProvider.ProviderTests/Schemas/v3 and add test like this https://github.com/fsprojects/SwaggerProvider/blob/master/tests/SwaggerProvider.ProviderTests/v3/Swagger.I0173.Tests.fs to check that TP works on this schema and manually check return type before merge/release |
|
added a sample and tests, thanks! |
|
Does it look good now? |
|
@jkone27 does it already work for you? |
jkone27
commented
Apr 22, 2023
jkone27
commented
Apr 22, 2023
tests/SwaggerProvider.ProviderTests/SwaggerProvider.ProviderTests.fsproj
Show resolved
Hide resolved
|
thanks for patching my changes @sergey-tihon 🎸 |
|
@jkone27 thank you for the fix, released in v2.0.0-beta8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tries to fix: #219.
@sergey-tihon