Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings #420

Merged
merged 30 commits into from
Apr 27, 2024
Merged

Add bindings #420

merged 30 commits into from
Apr 27, 2024

Conversation

SilkyFowl
Copy link
Contributor

@SilkyFowl SilkyFowl commented Apr 19, 2024 •
edited
Loading

add bindings for AvaloniaObject ~ TextBox, Flyout

  • Add binding of .net event.
  • Changed setter and compare function in IAvaloniaList<'T>'s binding to avoid unnecessary updates.
  • Code placement is tentative.

SilkyFowl added 23 commits April 17, 2024 18:47
@SilkyFowl
fix classes and styles properties on StyledElement
2dce4df 
- fix classes property on StyledElement.
- move styles property to IStyleHost.fs.
@SilkyFowl
control catalog: add styles demo back
883539d 
- add styles demo back
- update styles.xaml for FluentTheme
@SilkyFowl
fix IStyleHost.styles
de6c577 
- compare list of IStyle correctly
- setter should also update Resources
@SilkyFowl
add tests for IStyleHost.styles and Control.classes properties.
b61fb25
@SilkyFowl
add dataTemplates property.
b787bb2
@SilkyFowl
add onPropertyChanged event.
a5942b8
@SilkyFowl
add Net Event Attr functions.
d33a7bd
@SilkyFowl
add Visual DSL functions.
c229623
@SilkyFowl
use nameof expression
19b68aa
@SilkyFowl
add Layoutable DSL functions.
f42c4eb
@SilkyFowl
add InputElement DSL functions.
729ba9f
@SilkyFowl
add Control DSL functions.
35ee9f0
@SilkyFowl
add Inline DSL functions.
023dde8
@SilkyFowl
add TextDecoration DSL functions.
e3e4dc3
@SilkyFowl
add TextBlock DSL functions.
305d1b8
@SilkyFowl
add Image DSL functions.
540dc68
@SilkyFowl
move stryles DSL into StyledElement.fs
4230295
@SilkyFowl
add Flyout DSL functions.
11bd931
@SilkyFowl
refactor subscription function if passing event source, to use AddHan…
7276821 
…dler/RemoveHandler.
@SilkyFowl
add TemplatedControl bindings.
3f00708
@SilkyFowl
add TextBox bindings.
86e8af8
@SilkyFowl
add ItemsControl bindings.
392699b
@SilkyFowl
Type parameters Modified to explicitly.
7d0d13f
@JaggerJo JaggerJo marked this pull request as ready for review April 20, 2024 08:26
@JaggerJo
Copy link
Member

Really good work 👍

There are a few small things we need to do before merging (check comments).

@JaggerJo JaggerJo closed this Apr 21, 2024
@JaggerJo JaggerJo reopened this Apr 21, 2024
@SilkyFowl
documentation for updating Classes' standard classes
410d228 
Expanded the documentation for the `patchStandardClasses` function, which updates the standard classes of `Classes`, with detailed explanations about the mixture of standard classes and pseudoclasses.
@SilkyFowl
fix isPseudoClass
92e67be 
- StartsWith ... use Char instead of String.
- update comment.
@SilkyFowl
move dataTemplates binding functions to Control.fs
1f1464b
@SilkyFowl
Remove onTextChanged (TextBox.TextChangingEvent -> unit) binding.
7107231
@SilkyFowl
add test for AttrBuilder<'t>.CreateSubscription<'arg>(name, factory, …
f75941f 
…func, ?subPatchOptions)
@SilkyFowl
Refactor list / AvaloniaList / IList value bindings
d05943b 
- Add helper function for IList<'t>.
- Use helper function instead of custom Internals functions.
- For list<'t> binding, remove custom compare function.
@SilkyFowl
fix compare function.
a3226c1
@SilkyFowl
Copy link
Contributor Author

I've made revisions based on the review comments. Please check

JaggerJo
JaggerJo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@JaggerJo JaggerJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work 🎉

@SilkyFowl
Copy link
Contributor Author

Thank you very much.
Please let me know if there is anything I should be doing to merge, because I'm missing out.

@JaggerJo JaggerJo merged commit bca10e4 into fsprojects:master Apr 27, 2024
1 check passed
@JaggerJo
Copy link
Member

Thank you very much. Please let me know if there is anything I should be doing to merge, because I'm missing out.

I just merged it. Assumed the author can merge after a PR is approved.

This was referenced May 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Numpsy Numpsy Numpsy left review comments

@JaggerJo JaggerJo JaggerJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SilkyFowl @JaggerJo @Numpsy