Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with an issue when
updateChart()
method doesn't work properly.Assume we have a component that needs to pass additional arguments to Chartist listener using
bind
. Like in this exampleIn the current implementation,
react-chartist
component binds additional data to listeners only once, when the new chart instance is created. But in the above example, we need to bind new data to listener each time whenrender()
method of theComplexComponent
is called.To fix this issue I added new
forceRecreation
boolean prop toreact-chartist
component. If this prop has a true value, we unbind all listeners from the existing instance of Chartist graph and create the new instance of it from scratch in each call ofupdateChart()
method.