Fix: Sender is not always required when sending an SMS, as SMS gatewa…

…y providers often have it optional
fotografde · Aug 28, 2017 · 7875e85 · 7875e85
1 parent 4981bac
commit 7875e85
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/Lib/Network/Sms/CakeSms.php b/Lib/Network/Sms/CakeSms.php
@@ -211,6 +211,9 @@ public function from($phoneNumber = null) {
 		if ($phoneNumber === null) {
 			return $this->_from;
 		}
+		if (empty($phoneNumber)) {
+			return $this;
+		}
 		return $this->_setPhoneNumber('_from', $phoneNumber);
 	}
 

diff --git a/Test/Case/Lib/Network/Sms/CakeSmsTest.php b/Test/Case/Lib/Network/Sms/CakeSmsTest.php
@@ -2,6 +2,10 @@
 App::uses('CakeSms', 'Sms.Network/Sms');
 App::uses('View', 'View');
 
+/**
+ * Class CakeSmsTest
+ * @property CakeSms $CakeSms
+ */
 class CakeSmsTest extends CakeTestCase {
 
 	public function setUp()
@@ -96,9 +100,15 @@ public function testValidatePhoneNumber1() {
 		$this->CakeSms->to('123456789');
 	}
 
-	public function testFrom() {
+	public function testFromSetEmpty() {
+		$this->CakeSms->from('');
+	}
+
+	public function testFromGetEmpty() {
 		$this->assertSame('', $this->CakeSms->from());
+	}
 
+	public function testFromGet() {
 		$this->CakeSms->from('+49123456789');
 		$this->assertSame('+49123456789', $this->CakeSms->from());
 	}