Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ledger): improve ledger connect flow #44

Merged
merged 16 commits into from
Mar 7, 2025
Merged

feat(ledger): improve ledger connect flow #44

merged 16 commits into from
Mar 7, 2025

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Mar 3, 2025 •
edited
Loading

Pull Request Checklist

Before Submission

Description

This PR turns ledger connect manually in the first try.

Additional Notes

By submitting this pull request, I confirm that:

  • My contribution is made under the Business Source License
  • I grant Forbole Technology Limited a perpetual, worldwide, non-exclusive license to use my contribution under the
    project's
    license terms
  • I have the authority to make this contribution and license it appropriately

@dadamu dadamu marked this pull request as draft March 3, 2025 10:04
@dadamu dadamu marked this pull request as ready for review March 3, 2025 10:09
@dadamu dadamu changed the title feat(ledger): manual ledger connect feat(ledger): make ledger connect manually Mar 3, 2025
@dadamu dadamu changed the title feat(ledger): make ledger connect manually feat(ledger): manual ledger connect Mar 3, 2025
@dadamu dadamu requested a review from 0x7u March 3, 2025 10:12
dadamu added 13 commits March 5, 2025 14:38
@dadamu
chore: update loading spinner
ac27e74
@dadamu
chore: update ledger connecting image
187d222
@dadamu
feat(account-management): add loading ui to manage accounts page
4b28eb8
@dadamu
fix(account-management): add key prop to mapped loading placeholders
e333673
@dadamu
feat(account-management): add walletType prop to ManageAccounts for b…
9c260cf 
…etter context
@dadamu
style(account-management): improve button styling and formatting in M…
267f129 
…anageAccounts and LedgerConnectForImport
@dadamu
feat(ledger-connection): update button text based on connection statu…
33e8d49 
…s and send Kaspa app command
@dadamu
feat(ledger-wallet): redirect to manage accounts full page when click…
2c179ff 
…ing add account
@dadamu
feat(ledger-connect): update connection button text and improve image…
d8fabc7 
… dimensions
@dadamu
feat(ledger-transport): add error handling for Kaspa app opening and …
ab31001 
…display toast notification
@dadamu
feat: disable deploy and mint for ledger in dashboard
747e4bd
@dadamu
feat(ledger-support): disable krc20 sending for ledger
d034957
@dadamu
Merge branch 'main' of github.com:forbole/kastle into feat/manual-led…
7780d21 
…ger-connect
@dadamu dadamu changed the title feat(ledger): manual ledger connect feat(ledger): improve ledger connect flow Mar 7, 2025
@dadamu dadamu merged commit f5dde20 into main Mar 7, 2025
1 check passed
@0x7u 0x7u mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x7u 0x7u 0x7u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadamu @0x7u