Fix #2072 throw an exception instead of a crash for unknown type plat… #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbark
reviewed
Feb 16, 2025
| if (result is bool) { | ||
| isSupported = result; | ||
| } else { | ||
| throw StripeException( |
There was a problem hiding this comment.
That would then result in a different exception rather than a fix. Did you find out what the result contains if not bool?
There was a problem hiding this comment.
sorry forgot to force push 😂
…form pay supported
remonh87
force-pushed
the
fix-2072-unknown-type
branch
from
d23c489 to
31cee71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…form pay supported