Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office 2010 and Windows8 StartScreenTabControl style and other minor fixes #249

Closed
wants to merge 5 commits into from

Conversation

maurosampietro
Copy link
Contributor

I created a generic StartScreenTabControl style suitable for Office2010 and Windows8 with and without dwm. The old StartScreenTabControl is now a specialized version for Office2013.

Office 2013 StatusBar height should be 23, with no border margin etc.

@maurosampietro
Copy link
Contributor Author

Project files are not changed inspite git says i added and removed everything.
I think nuget/restore is responsible of this to happen.

@batzen
Copy link
Member

batzen commented Jan 19, 2016

First thanks for contributing and i don't want to sound rude, so please understand that it's just emotionless technical when i write something.

When you didn't change the project files, don't commit them (or at least do a manual diff and revert everything you didn't change explicitly).

As I said, i don't want duplicated style/template files for the StartScreenTabControl. Please don't introduce new ones. Beside that, the Office2013 file you introduced is even missing from this this PR.

As there is no StartScreen at all in Office 2010 and Windows 8 I'd like to have them fullscreen as in Office 2013. Otherwise (non fullscreen) they don't even make sense to me. The only styling issue which we currently have is when someone is using the StartScreen with said themes and DWM is not available. So in my opinion the solution can't be to make the StartScreen non fullscreen for those themes but to somehow fix the 1-2 pixel issue in a different way.

To achieve margins with bound values there is already ThicknessConverter.

The StatusBar changes look good to me.

… and 4.5 projects. Removed Margins AttachedProperties and replaced its usage with ThicknessConverter
@maurosampietro
Copy link
Contributor Author

Hi batzen,
feel free to write down straight with me, i'm not getting offended.

At the moment the startscreen looks bad for styles different from office2013 so something has to be done (this is how it looks with dwm on Office2010 and Windows8). It's sure we cannot realease like this:

image

In office 2010 and windows 8 if dwm is used we can't use fullscreen startscreen because it does not cover entirely the glass titlebar and it looks very bad (only the left panel covers it). For that reason my idea was to make the startscreentabcontrol not cover the titlebar at all and then hide the caption and icon of the titlebar. I didn't do the latter for tech reasons yet .

It turns out it's not bad (just image there's no caption and icon):
image

I think the result is pretty cool with dwm disabled too. Tell me If you like this or not.
image

In case dwm is used if you like i can use fullscreen Office2013 style and try to cover the titlebar completely both on the left and right panels and see how it looks.

Just tell me your thoughts.

@batzen
Copy link
Member

batzen commented Jan 20, 2016

Now i get what you are trying to do.
I will implement it that way so you can see what i want to do in the future to prevent template duplication.

I think the window icon and caption can stay where they are in Office 2010 and Windows 8. If we also hide them people might get confused.

@batzen
Copy link
Member

batzen commented Jan 20, 2016

Do you want to create a new PR for your changes in RibbonStatusBar, or should i just add those?

@maurosampietro
Copy link
Contributor Author

There are a few other things to take care of for the status bar. I will create a new PR.

Mauro Sampietro
Inviato da iPhone

Il giorno 20 gen 2016, alle ore 18:03, Bastian Schmidt notifications@github.com ha scritto:

Do you want to create a new PR for your changes in RibbonStatusBar, or should i just add those?


Reply to this email directly or view it on GitHub.

@maurosampietro
Copy link
Contributor Author

"I think the window icon and caption can stay where they are in Office 2010 and Windows 8. If we also hide them people might get confused."

With regard to the above please consider that the left panel will also show the caption and maybe the icon (it could completely replace the titlebar in this case), so to avoid repetition a flag like 'HideTitleBarContent' to hide the caption and icon might be desirable.

@batzen
Copy link
Member

batzen commented Jan 21, 2016

Will track such a flag as part of #250 and might add it when working on that issue/enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants