-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Office 2010 and Windows8 StartScreenTabControl style and other minor fixes #249
Conversation
Project files are not changed inspite git says i added and removed everything. |
First thanks for contributing and i don't want to sound rude, so please understand that it's just emotionless technical when i write something. When you didn't change the project files, don't commit them (or at least do a manual diff and revert everything you didn't change explicitly). As I said, i don't want duplicated style/template files for the StartScreenTabControl. Please don't introduce new ones. Beside that, the Office2013 file you introduced is even missing from this this PR. As there is no StartScreen at all in Office 2010 and Windows 8 I'd like to have them fullscreen as in Office 2013. Otherwise (non fullscreen) they don't even make sense to me. The only styling issue which we currently have is when someone is using the StartScreen with said themes and DWM is not available. So in my opinion the solution can't be to make the StartScreen non fullscreen for those themes but to somehow fix the 1-2 pixel issue in a different way. To achieve margins with bound values there is already ThicknessConverter. The StatusBar changes look good to me. |
… and 4.5 projects. Removed Margins AttachedProperties and replaced its usage with ThicknessConverter
Now i get what you are trying to do. I think the window icon and caption can stay where they are in Office 2010 and Windows 8. If we also hide them people might get confused. |
Do you want to create a new PR for your changes in RibbonStatusBar, or should i just add those? |
There are a few other things to take care of for the status bar. I will create a new PR. Mauro Sampietro
|
"I think the window icon and caption can stay where they are in Office 2010 and Windows 8. If we also hide them people might get confused." With regard to the above please consider that the left panel will also show the caption and maybe the icon (it could completely replace the titlebar in this case), so to avoid repetition a flag like 'HideTitleBarContent' to hide the caption and icon might be desirable. |
Will track such a flag as part of #250 and might add it when working on that issue/enhancement. |
I created a generic StartScreenTabControl style suitable for Office2010 and Windows8 with and without dwm. The old StartScreenTabControl is now a specialized version for Office2013.
Office 2013 StatusBar height should be 23, with no border margin etc.