fix interactions between stats and packet forwarding testcases #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an earlier test run sends a packet through the port, and if the switch takes a second or so to make those counter updates visible to OpenFlow, then this test would fail because the port stats would be higher than expected. Changing the conditional reduces the usefulness of the test because it won't catch overcounting errors, but it's necessary to make it correct.
This code wasn't doing the stats transaction correctly since it didn't account for the switch splitting the stats entries across multiple messages.
Same reason as 6d61817.
|
ACK |
|
ABAT: START_MERGE: Log file at http://vbs21/abat/2015.04.10.2233-m.oftest.master/abat.log |
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
bsn-abat
pushed a commit
that referenced
this pull request
Apr 10, 2015
fix interactions between stats and packet forwarding testcases (#177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @harshsin
A switch that periodically syncs stats to the OpenFlow layer (like IVS) could
fail these stats tests because they didn't account for the delay in the stats
updates from previous tests. They already accounted for the delay in stats for
their own test.