dataplane: pass protocol number to bind() instead of socket() #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the bind call much faster because it doesn't need to unregister the protocol hook, which requires waiting for an RCU grace period (~10ms). Linux 3.14 and later optimize this internally, but Ubuntu 14.04 doesn't have a recent enough kernel. The Python socket library does the htons for us when creating the sockaddr for bind. This change reduces the time to run IVS automated tests by half.
|
SELF-ACK |
|
ABAT: START_MERGE: Log file at http://vbs21/abat/2015.03.19.0810-m.oftest.master/abat.log |
bsn-abat
pushed a commit
that referenced
this pull request
Mar 19, 2015
dataplane: pass protocol number to bind() instead of socket() (#169)
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @rlane
This makes the bind call much faster because it doesn't need to unregister the
protocol hook, which requires waiting for an RCU grace period (~10ms). Linux
3.14 and later optimize this internally, but Ubuntu 14.04 doesn't have a
recent enough kernel.
The Python socket library does the htons for us when creating the sockaddr for
bind.
This change reduces the time to run IVS automated tests by half.