Use a short timeout when polling for packets. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ABAT: START_MERGE: Log file at http://vbs22/abat/2015.03.05.0102-m.oftest.master/abat.log |
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
bsn-abat
pushed a commit
that referenced
this pull request
Mar 5, 2015
Use a short timeout when polling for packets. (#165)
|
What was the reason for this change? |
|
There are a number of bigtap tests that iterate over all the ports on a switch, send a packet on each port, and expect a packet to be received on the next port. When the oftest polls for the packet it expects to receive, the arrival of the packet seems to be delayed, causing the poll (without timeout) to miss the packet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: trivial