Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): Use required root_hash options #452

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ryanschneider
Copy link
Contributor

📝 Summary

As part of #429 the check was added to prevent start-up if the root_hash_use_sparse_trie and root_hash_compare_sparse_trie values weren't set correctly. This updates those values for the playground (I'm not sure if we want to update other config examples as well).

💡 Motivation and Context

Without this change cargo run --bin rbuilder run config-playground.toml (correctly) fails with:

Error: root_hash_use_sparse_trie=true and root_hash_compare_sparse_trie=false must be set, otherwise node will produce incorrect blocks or confusing error messages. These settings are enforced temporarily because upstream parallel root hash implementation is not correct.

Location:
    crates/rbuilder/src/live_builder/base_config.rs:303:13

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ferranbt ferranbt merged commit 767324d into develop Feb 27, 2025
3 of 4 checks passed
@ferranbt ferranbt deleted the playground-config-fix branch February 27, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants