-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward validator registrations without decoding #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code generally looks good. some notes:
- there are no tests for this AFACIT, we should test somehow before putting into a release
- there is a change in behavior here where mev-boost no longer verifies the validator registrations deserialize correctly; it should be fine (the relay will still do this, etc) but is somewhat of a notable change
- im not going all of the go APIs with a fine-toothed comb, so could be missing something with error handling, request processing, etc
Agreed. I've pushed some basic tests to ensure the forwarding works as expected.
Also agreed. But I feel that this is fine. The builder/relay should check this. Keep in mind it's possible for clients to connect directly to a single builder/relay and skip the mev-boost middleman. Meaning they need to handle bad inputs too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice code and docs/comments!
📝 Summary
register_validator.go
file.wrapUserAgent
method.✅ I have run these commands
make lint
make test-race
go mod tidy