Sleep to fix reth socket permissions #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bakhtin <a@bakhtin.net>
MoeMahhouk
reviewed
Feb 26, 2025
Comment on lines
+64
to
+66
|
|
||
| echo "Sleeping to fix socket permissions after reth has started..." | ||
| sleep 5 |
There was a problem hiding this comment.
or we can can move the permission setup to where it is needed. For example, if these permission are for the rbuilder to work with no errors, then we can move it to rbuilder init instead since it runs after the reth init, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing I revealed a race condition in the Reth service init script.
We start Reth in the background with
start-stop-daemon, wait for IPC socket to appear, and fix its permissions to allow shared access to Rbuilder. But it seems there is a race condition as Reth reverts the IPC socket permissions after we fixed it withchmod. It happens a couple of seconds after Reth starts and creates a IPC socket.This PR introduces additional 5 seconds sleep to enable Reth to set IPC socket permissions before we
chmodit later.