Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of emtpy blocklist creation #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bakhtin
Copy link
Contributor

@bakhtin bakhtin commented Feb 25, 2025

Revert the changes from https://github.com/flashbots/meta-evm/pull/61/files#diff-1b9613527a68a64974034a69196953b572341af92125ddfefd0b044530b11abc to allow running rbuilder when no blocklist is required.

Signed-off-by: bakhtin <a@bakhtin.net>
Copy link
Collaborator

@MoeMahhouk MoeMahhouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit dangerous though as it would run without any blocklist.
Maybe it should recognize such a scenario and runs rbuilder in dry-run mode or throw a warning or an alert just in case, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants