Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SEO information #167

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Fix SEO information #167

merged 4 commits into from
Apr 29, 2024

Conversation

gkoscky
Copy link
Contributor

@gkoscky gkoscky commented Apr 25, 2024

Two fixes here:

  1. Correct SEO information metadata
    These values were not properly set due to a number of misconfigurations and conflicts in docusaurus.config.js. So I cleaned it up and set the correct values for proper meta-tag generation. New values:

    • Title: Flashbots Writings
    • Description: A collection of articles and papers from Flashbots.
  2. Avoid repeated title in homepage
    The blog's homepage will duplicate the title if you give it as a parametet. So if you pass it the title "Flashbots Writings", the final title will be "Flashbots Writings | Flashbots Writings". To avoid that I removed the parameter from the frontpage template

To test everything, check the values and generated cards in Opengraph.xyz:
https://www.opengraph.xyz/url/https%3A%2F%2Fflashbots-writings-website-git-gkoscky-social-537084-flashbots.vercel.app

gkoscky added 4 commits April 25, 2024 12:14
I can't make it work locally, so maybe it's a build process thing?
Property name should be `metadatas`, not `metadata`
Do no pass `BlogLayout.title`, so we don't have "Title | Title" as the title
@gkoscky gkoscky requested a review from deadpine April 25, 2024 14:28
@gkoscky gkoscky self-assigned this Apr 25, 2024
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flashbots-writings-website ✅ Ready (Inspect) Visit Preview Apr 25, 2024 2:28pm

Copy link
Collaborator

@deadpine deadpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Gabe!

@deadpine deadpine merged commit ea9694c into main Apr 29, 2024
3 checks passed
@deadpine deadpine deleted the gkoscky/social-media-info branch April 29, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants