BusinessInsider: multiple Updates #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
|
Hey @addie9800 thanks for fixing this 👍 Could you explain to me why this PR also adds a new test case for the publisher? |
I just realized the mistake in my train of thought: My thought was that with the updated selector, we would also need to update the testcase, because I was thinking of the version in the PR with the body added to the unit tests. |
|
I have restored the testcaseto (almost) what it was earlier |
|
@addie9800 Could you open your changes in a new PR that does not alter the test case? |
|
@addie9800 Thanks a lot. I will close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the title parser due to the former version using the <title> tags value which doesn't coincide with the actual headline of the article.
I have also addressed the issue of external contents being parsed with errors